pedro/DiveSim
1
0
Fork 0
Code Issues 74 Pull requests Projects Releases 1 Packages Wiki Activity Actions

[P2] Reef Runner keyboard controls stop after clicking any game button #32

New issue
Closed
opened 2026-10-27 02:59:42 +00:00 by pedro · 1 comment
pedro commented 2026-10-27 02:59:42 +00:00
Owner
Copy link

Priority: P2
Type: bug (regression from #22)
Source: project review requested 2026-10-26 (second pass)

Location: src/ReefRunner.tsx:42

Problem and evidence

The keydown handler ignores every key whose target is inside a button. Clicking Sound, Deeper/Shallower or Pause focuses that button, after which arrows, W/S, B and Escape do nothing: depth stays 72.8 ft with ArrowDown held, and Escape does not resume after a mouse Pause.

Suggested correction

For focused buttons/links skip only their native activation keys (Space, Enter); keep skipping all keys for editable fields.

Acceptance criteria

Browser regression: steering and Escape work after clicking game buttons while Space still activates a focused button; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P2 Type: bug (regression from #22) Source: project review requested 2026-10-26 (second pass) Location: `src/ReefRunner.tsx:42` Problem and evidence The keydown handler ignores every key whose target is inside a button. Clicking Sound, Deeper/Shallower or Pause focuses that button, after which arrows, W/S, B and Escape do nothing: depth stays 72.8 ft with ArrowDown held, and Escape does not resume after a mouse Pause. Suggested correction For focused buttons/links skip only their native activation keys (Space, Enter); keep skipping all keys for editable fields. Acceptance criteria Browser regression: steering and Escape work after clicking game buttons while Space still activates a focused button; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.
pedro commented 2026-10-27 04:16:30 +00:00
Author
Owner
Copy link

Fixed on maintenance/review-2026-10-27 in e573b1d — PR #40.

Focused buttons keep only native Space/Enter; steering, bank and Escape reach the game. Chromium regression.

Branch verification: pnpm verify 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: docs/MAINTENANCE-2026-10-27.md. Closes on merge of PR #40.

Fixed on `maintenance/review-2026-10-27` in `e573b1d` — [PR #40](https://git.guresky.com/pedro/DiveSim/pulls/40). Focused buttons keep only native Space/Enter; steering, bank and Escape reach the game. Chromium regression. Branch verification: `pnpm verify` 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: `docs/MAINTENANCE-2026-10-27.md`. Closes on merge of PR #40.
pedro closed this issue 2026-10-27 05:39:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
t3/project-branding-style-guide
maintenance/review-2026-10-27
codex/release-r1
R1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pedro/DiveSim#32
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?