pedro/DiveSim
1
0
Fork 0
Code Issues 74 Pull requests Projects Releases 1 Packages Wiki Activity Actions

[P2] Preserve native keyboard button activation in Reef Runner #22

New issue
Closed
opened 2026-10-27 01:59:15 +00:00 by pedro · 1 comment
pedro commented 2026-10-27 01:59:15 +00:00
Owner
Copy link

Priority: P2
Type: bug
Source: project review requested 2026-10-26

Location: src/ReefRunner.tsx:40

Problem and evidence

The global handler prevents Space default behavior for focused buttons. Start dive, Resume, Sound and Back to simulator cannot be activated with Space; while playing Space can fire instead of activating the focused control.

Suggested correction

Exempt buttons, links, disclosures and editable elements from game shortcuts, following the simulator keyboard policy.

Acceptance criteria

Browser validation covers focused controls and body shortcuts during ready, paused and active states; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P2 Type: bug Source: project review requested 2026-10-26 Location: `src/ReefRunner.tsx:40` Problem and evidence The global handler prevents Space default behavior for focused buttons. Start dive, Resume, Sound and Back to simulator cannot be activated with Space; while playing Space can fire instead of activating the focused control. Suggested correction Exempt buttons, links, disclosures and editable elements from game shortcuts, following the simulator keyboard policy. Acceptance criteria Browser validation covers focused controls and body shortcuts during ready, paused and active states; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.
pedro commented 2026-10-27 02:06:39 +00:00
Author
Owner
Copy link

Fixed and pushed to main. Reef Runner ignores game shortcuts on native interactive/editable controls and ignores already-handled or modified shortcuts. Chromium checks verify Space on Start dive, Pause, Resume dive, Sound and Back to simulator, plus global Escape on the game background. All 138 tests and typecheck/build/offline/release checks pass. Browser regression: scripts/check-maintenance-browser.mjs.

Fixed and pushed to main. Reef Runner ignores game shortcuts on native interactive/editable controls and ignores already-handled or modified shortcuts. Chromium checks verify Space on Start dive, Pause, Resume dive, Sound and Back to simulator, plus global Escape on the game background. All 138 tests and typecheck/build/offline/release checks pass. Browser regression: scripts/check-maintenance-browser.mjs.
pedro closed this issue 2026-10-27 02:06:39 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
t3/project-branding-style-guide
maintenance/review-2026-10-27
codex/release-r1
R1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pedro/DiveSim#22
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?