pedro/DiveSim
1
0
Fork 0
Code Issues 74 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Reef Runner bank keyboard shortcut changes the run while paused #51

New issue
Closed
opened 2026-10-31 04:06:57 +00:00 by pedro · 1 comment
pedro commented 2026-10-31 04:06:57 +00:00
Owner
Copy link

The B key invokes bank() without the pause guard applied to the Fire shortcut and bank button.

Reproduce: Start dive, Pause, press B. The Paused overlay stays visible but the run becomes Returning automatically; resuming forces ascent instead of continuing exploration.

Location: src/game/ReefRunner.tsx keydown handler.

Acceptance: B has no effect while paused; banking still works when actively swimming, including when game buttons have focus. Add a focused browser regression.

The B key invokes bank() without the pause guard applied to the Fire shortcut and bank button. Reproduce: Start dive, Pause, press B. The Paused overlay stays visible but the run becomes Returning automatically; resuming forces ascent instead of continuing exploration. Location: src/game/ReefRunner.tsx keydown handler. Acceptance: B has no effect while paused; banking still works when actively swimming, including when game buttons have focus. Add a focused browser regression.
pedro commented 2026-10-31 19:26:13 +00:00
Author
Owner
Copy link

Fixed in 3dd512d; integrated in main at 3dd512d and deployed to production (deploy run 734 succeeded; hosted assets verified against the local build). pnpm verify: 176/176 tests, offline retention, typecheck, build and release checks pass.

Fixed in 3dd512d; integrated in main at 3dd512d and deployed to production (deploy run 734 succeeded; hosted assets verified against the local build). `pnpm verify`: 176/176 tests, offline retention, typecheck, build and release checks pass.
pedro closed this issue 2026-10-31 19:26:13 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
t3/project-branding-style-guide
maintenance/review-2026-10-27
codex/release-r1
R1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pedro/DiveSim#51
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?