pedro/DiveSim
1
0
Fork 0
Code Issues 74 Pull requests Projects Releases 1 Packages Wiki Activity Actions

[P3] Other tabs report "Update download failed" after an update succeeds #36

New issue
Closed
opened 2026-10-27 02:59:42 +00:00 by pedro · 1 comment
pedro commented 2026-10-27 02:59:42 +00:00
Owner
Copy link

Priority: P3
Type: bug
Source: project review requested 2026-10-26 (second pass)

Location: src/offline.ts:33-34

Problem and evidence

Any watched service worker becoming redundant sets the failure state, including workers replaced normally. Tab A installs version 1; tab B accepts version 2; tab A then shows "Update download failed. Your installed copy is unchanged." with a retry button. Two updates while one is waiting cause the same message.

Suggested correction

Count redundancy as a failure only for a worker that never reached installed; clear the failure when a worker installs.

Acceptance criteria

Browser lifecycle regression for both scenarios; offline checks pass; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P3 Type: bug Source: project review requested 2026-10-26 (second pass) Location: `src/offline.ts:33-34` Problem and evidence Any watched service worker becoming redundant sets the failure state, including workers replaced normally. Tab A installs version 1; tab B accepts version 2; tab A then shows "Update download failed. Your installed copy is unchanged." with a retry button. Two updates while one is waiting cause the same message. Suggested correction Count redundancy as a failure only for a worker that never reached installed; clear the failure when a worker installs. Acceptance criteria Browser lifecycle regression for both scenarios; offline checks pass; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.
pedro commented 2026-10-27 04:16:30 +00:00
Author
Owner
Copy link

Fixed on maintenance/review-2026-10-27 in 90c935a — PR #40.

Redundancy counts as failure only before a worker installed. Two-tab and double-update Chromium lifecycle reproductions now show "Available offline".

Branch verification: pnpm verify 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: docs/MAINTENANCE-2026-10-27.md. Closes on merge of PR #40.

Fixed on `maintenance/review-2026-10-27` in `90c935a` — [PR #40](https://git.guresky.com/pedro/DiveSim/pulls/40). Redundancy counts as failure only before a worker installed. Two-tab and double-update Chromium lifecycle reproductions now show "Available offline". Branch verification: `pnpm verify` 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: `docs/MAINTENANCE-2026-10-27.md`. Closes on merge of PR #40.
pedro closed this issue 2026-10-27 05:39:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
t3/project-branding-style-guide
maintenance/review-2026-10-27
codex/release-r1
R1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: pedro/DiveSim#36
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?