[P3] Planner replay speed follows the live dive's NDL slowdown #34

New issue

Closed

opened 2026-10-27 02:59:42 +00:00 by pedro · 1 comment

pedro commented

2026-10-27 02:59:42 +00:00

Owner

Priority: P3
Type: bug
Source: project review requested 2026-10-26 (second pass)

Location: src/App.tsx:3025

Problem and evidence

Planner Mode receives effectiveSpeed, which is forced to 1× when the paused live dive has 5:00 or less of no-decompression time. A 21-minute planned profile then replays in real time and shows 1×.

Suggested correction

Pass the user-selected playback speed to Planner Mode.

Acceptance criteria

Planner replay uses the selected speed regardless of live NDL; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P3 Type: bug Source: project review requested 2026-10-26 (second pass) Location: `src/App.tsx:3025` Problem and evidence Planner Mode receives `effectiveSpeed`, which is forced to 1× when the paused live dive has 5:00 or less of no-decompression time. A 21-minute planned profile then replays in real time and shows 1×. Suggested correction Pass the user-selected playback speed to Planner Mode. Acceptance criteria Planner replay uses the selected speed regardless of live NDL; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

pedro referenced this issue from a commit

2026-10-27 03:53:54 +00:00

Replay planner profiles at the selected speed during live NDL slowdown (#34)

pedro referenced this issue from a pull request that will close it,

2026-10-27 03:54:09 +00:00

Fix second review findings #26–#39 #40

pedro commented

2026-10-27 04:16:30 +00:00

Author

Owner

Fixed on maintenance/review-2026-10-27 in fcef187 — PR #40.

Planner receives the selected speed. Chromium regression fails with the old prop.

Branch verification: pnpm verify 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: docs/MAINTENANCE-2026-10-27.md. Closes on merge of PR #40.

Fixed on `maintenance/review-2026-10-27` in `fcef187` — [PR #40](https://git.guresky.com/pedro/DiveSim/pulls/40). Planner receives the selected speed. Chromium regression fails with the old prop. Branch verification: `pnpm verify` 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: `docs/MAINTENANCE-2026-10-27.md`. Closes on merge of PR #40.

pedro closed this issue

2026-10-27 05:39:05 +00:00

pedro referenced this issue

2026-10-27 05:40:49 +00:00

[P3] Hashed assets are not cached long-term as documented #39

pedro referenced this issue

2026-10-27 05:40:49 +00:00

Fix second review findings #26–#39 #40