[P2] Opening Reef Runner unmounts the simulator, losing planner edits and re-applying shared plans #30

New issue

Closed

opened 2026-10-27 02:59:42 +00:00 by pedro · 1 comment

pedro commented

2026-10-27 02:59:42 +00:00

Owner

Priority: P2
Type: bug
Source: project review requested 2026-10-26 (second pass)

Location: src/App.tsx:982

Problem and evidence

if (gameOpen) return <ReefRunner/> unmounts the whole shell. (a) Planner edits (depth 100 ft, two segments) are lost after visiting Reef Runner. (b) After a shared-plan link and a units change, returning from the game re-reads #plan= and resets units/gases/circuit. (c) If the planner is requested while in the game, the Planner Mode button no longer opens the dialog because its show effect ran without the element.

Suggested correction

Keep the shell mounted (hidden) while the game is shown and open the planner dialog only when the game is not displayed.

Acceptance criteria

Browser regression for (a)–(c); existing game and planner checks pass; pnpm verify passes.

Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

Priority: P2 Type: bug Source: project review requested 2026-10-26 (second pass) Location: `src/App.tsx:982` Problem and evidence `if (gameOpen) return <ReefRunner/>` unmounts the whole shell. (a) Planner edits (depth 100 ft, two segments) are lost after visiting Reef Runner. (b) After a shared-plan link and a units change, returning from the game re-reads `#plan=` and resets units/gases/circuit. (c) If the planner is requested while in the game, the Planner Mode button no longer opens the dialog because its show effect ran without the element. Suggested correction Keep the shell mounted (hidden) while the game is shown and open the planner dialog only when the game is not displayed. Acceptance criteria Browser regression for (a)–(c); existing game and planner checks pass; pnpm verify passes. Scope: maintenance of the educational simulator. Preserve historical R1 acceptance and operational-validation limits.

pedro referenced this issue from a pull request that will close it,

2026-10-27 03:54:09 +00:00

Fix second review findings #26–#39 #40

pedro commented

2026-10-27 04:16:30 +00:00

Author

Owner

Fixed on maintenance/review-2026-10-27 in ce6db2e — PR #40.

Shell stays mounted (hidden) while Reef Runner is shown; planner drafts, live units after a shared link and planner requests during the game survive. Chromium regression.

Branch verification: pnpm verify 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: docs/MAINTENANCE-2026-10-27.md. Closes on merge of PR #40.

Fixed on `maintenance/review-2026-10-27` in `ce6db2e` — [PR #40](https://git.guresky.com/pedro/DiveSim/pulls/40). Shell stays mounted (hidden) while Reef Runner is shown; planner drafts, live units after a shared link and planner requests during the game survive. Chromium regression. Branch verification: `pnpm verify` 145 tests and release budgets; Chromium/Firefox/WebKit review, replay, compatibility and offline lifecycle checks; CI verify runs #111/#112 pass. Record: `docs/MAINTENANCE-2026-10-27.md`. Closes on merge of PR #40.

pedro closed this issue

2026-10-27 05:39:05 +00:00

pedro referenced this issue from a commit

2026-10-27 05:39:07 +00:00

Keep the simulator mounted while Reef Runner is shown (#30)

pedro referenced this issue

2026-10-27 05:40:49 +00:00

[P3] Hashed assets are not cached long-term as documented #39

pedro referenced this issue

2026-10-27 05:40:49 +00:00

Fix second review findings #26–#39 #40